Skip to content

fix: ensure correct special case for complex-valued input in sqrt#987

Merged
kgryte merged 3 commits intodata-apis:mainfrom
ev-br:sqrt_spec_case_typo
Feb 5, 2026
Merged

fix: ensure correct special case for complex-valued input in sqrt#987
kgryte merged 3 commits intodata-apis:mainfrom
ev-br:sqrt_spec_case_typo

Conversation

@ev-br
Copy link
Member

@ev-br ev-br commented Jan 16, 2026

Fix what looks like a small typo in a docstring.
Caught it in data-apis/array-api-tests#409

@kgryte
Copy link
Contributor

kgryte commented Jan 25, 2026

@ev-br Does this need to be backported?

@kgryte kgryte changed the title MAINT: fix a typo in a special case of sqrt fix: ensure correct special case for complex-valued input in sqrt Jan 25, 2026
@kgryte kgryte added this to the v2025 milestone Jan 25, 2026
@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. topic: Complex Data Types Complex number data types. labels Jan 25, 2026
@ev-br
Copy link
Member Author

ev-br commented Jan 25, 2026

Might very well be too minor to bother backporting IMO.

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ev-br Given that there are two mistakes, would you mind backporting to previous revisions of the standard? Can be done in this PR.

@kgryte kgryte added the Backport Changes involve backporting to previous versions. label Feb 5, 2026
@ev-br
Copy link
Member Author

ev-br commented Feb 5, 2026

backporting to previous revisions of the standard? Can be done in this PR.

Updated in 2022.12, 2023.12 and 2024.12

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 02ab761 into data-apis:main Feb 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance. topic: Complex Data Types Complex number data types.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants